HDFS-16242. JournalMetrics should add JournalId MetricTag. by Neilxzn · Pull Request #3494 · apache/hadoop

Neilxzn · 2021-09-28T10:33:18Z

Description of PR

https://issues.apache.org/jira/browse/HDFS-16242
JournalMetrics should add JournalId MetricTag to distinguish different nameservice journal metrics when JournalNode use ganglia sink or prometheus sink.

JMX

Before this patch, journal' jmx :

// jmx json
    {
    "name" : "Hadoop:service=JournalNode,name=Journal-nntest1",
    "Syncs60sNumOps" : 0,
    ...
    },
    {
   "name" : "Hadoop:service=JournalNode,name=Journal-nntest2",
   "Syncs60sNumOps" : 0,
   ... 
   }

After this patch, journal' jmx :

// jmx json
    {
    "name" : "Hadoop:service=JournalNode,name=Journal-nntest1",
    "tag.JournalId" : "nntest1",  // add this tag
    "Syncs60sNumOps" : 0,
   ...
    },
    {
   "name" : "Hadoop:service=JournalNode,name=Journal-nntest2", 
    "tag.JournalId" : "nntest2",
   "Syncs60sNumOps" : 0,
  ... 
    }

PrometheusSink

Before this patch, journal' prometheus export :

journal_node_syncs60s_num_ops{context="dfs",hostname="host"} 2

After this patch, journal' prometheus export :

journal_node_syncs60s_num_ops{context="dfs",journalid="nntest2",hostname="host"} 2
journal_node_syncs60s_num_ops{context="dfs",journalid="nntest1",hostname="host"} 75

How was this patch tested?

add test testJournalMetricTags

For code changes:

add JournalMetrics$getJournalId

hadoop-yetus · 2021-09-28T18:04:40Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 47s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	12m 53s		Maven dependency ordering for branch
+1 💚	mvninstall	24m 14s		trunk passed
+1 💚	compile	23m 44s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	compile	21m 49s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	checkstyle	4m 20s		trunk passed
+1 💚	mvnsite	3m 16s		trunk passed
+1 💚	javadoc	2m 24s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	3m 28s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	spotbugs	5m 41s		trunk passed
+1 💚	shadedclient	21m 45s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 27s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 8s		the patch passed
+1 💚	compile	20m 26s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javac	20m 26s		the patch passed
+1 💚	compile	18m 29s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	javac	18m 29s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	3m 33s		the patch passed
+1 💚	mvnsite	3m 11s		the patch passed
+1 💚	javadoc	2m 17s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	3m 28s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	spotbugs	6m 7s		the patch passed
+1 💚	shadedclient	22m 8s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	17m 15s		hadoop-common in the patch passed.
+1 💚	unit	225m 5s		hadoop-hdfs in the patch passed.
+1 💚	asflicense	1m 10s		The patch does not generate ASF License warnings.
		449m 58s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3494/1/artifact/out/Dockerfile
GITHUB PR	#3494
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux ec622a565571 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `84f3331`
Default Java	Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3494/1/testReport/
Max. process+thread count	3106 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3494/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Neilxzn · 2021-09-29T02:28:50Z

cc @aajisaka @adamantal . Would you take some time to review this patch? Thank you.

adamantal

The implementation looks good. Two whitespace errors

...project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalMetrics.java

...roject/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/server/TestJournalNode.java

1. remove empty space

Neilxzn · 2021-09-29T09:06:32Z

Thank you for your review. @adamantal

I commit it again to fix checkstyle error.

hadoop-yetus · 2021-09-29T15:02:58Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 9s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	12m 35s		Maven dependency ordering for branch
+1 💚	mvninstall	28m 28s		trunk passed
+1 💚	compile	28m 29s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	compile	24m 3s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	checkstyle	4m 27s		trunk passed
+1 💚	mvnsite	3m 41s		trunk passed
+1 💚	javadoc	2m 26s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	3m 32s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	spotbugs	7m 32s		trunk passed
+1 💚	shadedclient	29m 27s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 28s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 48s		the patch passed
+1 💚	compile	27m 45s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javac	27m 45s		the patch passed
+1 💚	compile	24m 19s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	javac	24m 19s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	4m 9s		the patch passed
+1 💚	mvnsite	3m 13s		the patch passed
+1 💚	javadoc	2m 8s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	3m 33s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	spotbugs	7m 56s		the patch passed
+1 💚	shadedclient	27m 27s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	17m 16s		hadoop-common in the patch passed.
-1 ❌	unit	98m 9s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+0 🆗	asflicense	0m 47s		ASF License check generated no output?
		362m 46s

Reason	Tests
Failed junit tests	hadoop.hdfs.TestEncryptionZonesWithKMS
	hadoop.hdfs.TestDecommission
	hadoop.hdfs.web.TestWebHdfsFileSystemContract
	hadoop.hdfs.TestReconstructStripedFileWithValidator

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3494/3/artifact/out/Dockerfile
GITHUB PR	#3494
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 3f80de784e3f 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `1d4e1b1`
Default Java	Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3494/3/testReport/
Max. process+thread count	3143 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3494/3/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2021-09-29T18:15:41Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 0s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	12m 31s		Maven dependency ordering for branch
+1 💚	mvninstall	26m 39s		trunk passed
+1 💚	compile	31m 52s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	compile	29m 21s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	checkstyle	5m 18s		trunk passed
+1 💚	mvnsite	4m 37s		trunk passed
+1 💚	javadoc	3m 7s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	4m 16s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	spotbugs	8m 30s		trunk passed
+1 💚	shadedclient	30m 23s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 29s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 57s		the patch passed
+1 💚	compile	30m 43s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javac	30m 43s		the patch passed
+1 💚	compile	26m 33s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	javac	26m 33s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	4m 38s		the patch passed
+1 💚	mvnsite	3m 51s		the patch passed
+1 💚	javadoc	2m 44s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	3m 40s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	spotbugs	7m 21s		the patch passed
+1 💚	shadedclient	25m 55s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	17m 18s		hadoop-common in the patch passed.
-1 ❌	unit	276m 24s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
-1 ❌	asflicense	1m 5s	/results-asflicense.txt	The patch generated 11 ASF License warnings.
		558m 50s

Reason	Tests
Failed junit tests	hadoop.hdfs.TestFileCreationClient
	hadoop.hdfs.TestFileConcurrentReader
	hadoop.hdfs.server.balancer.TestBalancer
	hadoop.hdfs.server.balancer.TestBalancerRPCDelay
	hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy
	hadoop.hdfs.TestHDFSFileSystemContract

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3494/2/artifact/out/Dockerfile
GITHUB PR	#3494
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux f65dbf31e849 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `1d4e1b1`
Default Java	Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3494/2/testReport/
Max. process+thread count	3134 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3494/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Neilxzn · 2021-09-30T02:50:17Z

The fail tests is due to java.lang.OutOfMemoryError. It is unrelated.

 java.lang.OutOfMemoryError: unable to create new native thread

...roject/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/server/TestJournalNode.java

adamantal

+1. Thanks! Will commit this if no objections.

hadoop-yetus · 2021-09-30T16:12:23Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 41s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	12m 41s		Maven dependency ordering for branch
+1 💚	mvninstall	20m 47s		trunk passed
+1 💚	compile	21m 6s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	compile	18m 36s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	checkstyle	3m 45s		trunk passed
+1 💚	mvnsite	3m 14s		trunk passed
+1 💚	javadoc	2m 19s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	3m 25s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	spotbugs	5m 41s		trunk passed
+1 💚	shadedclient	21m 57s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 28s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 8s		the patch passed
+1 💚	compile	20m 34s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javac	20m 34s		the patch passed
+1 💚	compile	18m 28s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	javac	18m 28s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	3m 36s		the patch passed
+1 💚	mvnsite	3m 10s		the patch passed
+1 💚	javadoc	2m 16s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	3m 22s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	spotbugs	6m 5s		the patch passed
+1 💚	shadedclient	22m 0s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	17m 21s		hadoop-common in the patch passed.
+1 💚	unit	224m 41s		hadoop-hdfs in the patch passed.
+1 💚	asflicense	1m 11s		The patch does not generate ASF License warnings.
		439m 19s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3494/4/artifact/out/Dockerfile
GITHUB PR	#3494
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 9048bd49350e 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `06babcb`
Default Java	Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3494/4/testReport/
Max. process+thread count	3104 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3494/4/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2021-09-30T18:08:36Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 57s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	12m 21s		Maven dependency ordering for branch
+1 💚	mvninstall	23m 54s		trunk passed
+1 💚	compile	23m 9s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	compile	19m 41s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	checkstyle	3m 52s		trunk passed
+1 💚	mvnsite	3m 9s		trunk passed
+1 💚	javadoc	2m 8s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	3m 6s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	spotbugs	5m 50s		trunk passed
+1 💚	shadedclient	24m 41s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 22s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 13s		the patch passed
+1 💚	compile	22m 19s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javac	22m 19s		the patch passed
+1 💚	compile	19m 34s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	javac	19m 34s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	3m 44s		the patch passed
+1 💚	mvnsite	3m 3s		the patch passed
+1 💚	javadoc	2m 5s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	3m 14s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	spotbugs	6m 17s		the patch passed
+1 💚	shadedclient	24m 52s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	17m 9s		hadoop-common in the patch passed.
-1 ❌	unit	324m 27s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 58s		The patch does not generate ASF License warnings.
		551m 34s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3494/5/artifact/out/Dockerfile
GITHUB PR	#3494
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 6df1b7d57b2d 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `fcfc7e7`
Default Java	Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3494/5/testReport/
Max. process+thread count	3135 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3494/5/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

adamantal · 2021-10-01T07:36:46Z

Merged to trunk, thanks for the contribution @Neilxzn

Contributed by Max Xie

add journalNode Id for metrics.

84f3331

adamantal reviewed Sep 29, 2021

View reviewed changes

...project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalMetrics.java Outdated Show resolved Hide resolved

...roject/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/server/TestJournalNode.java Show resolved Hide resolved

Neilxzn added 3 commits September 29, 2021 16:53

fix checkstyle

573de69

1. remove empty space

readd the empty line

f98cb22

remove the empty line

1d4e1b1

adamantal reviewed Sep 30, 2021

View reviewed changes

...roject/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/server/TestJournalNode.java Outdated Show resolved Hide resolved

Neilxzn added 2 commits September 30, 2021 16:51

fix some empty line checkstyle.

06babcb

fix some empty line checkstyle.

fcfc7e7

adamantal approved these changes Sep 30, 2021

View reviewed changes

adamantal merged commit bf9106c into apache:trunk Oct 1, 2021

HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022

HDFS-16242. JournalMetrics should add JournalId MetricTag. (apache#3494)

b292a45

Contributed by Max Xie

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HDFS-16242. JournalMetrics should add JournalId MetricTag.#3494

HDFS-16242. JournalMetrics should add JournalId MetricTag.#3494
adamantal merged 6 commits intoapache:trunkfrom
Neilxzn:feature/metric_add_jid

Neilxzn commented Sep 28, 2021 •

edited

Loading

Uh oh!

hadoop-yetus commented Sep 28, 2021

Uh oh!

Neilxzn commented Sep 29, 2021

Uh oh!

adamantal left a comment

Uh oh!

Uh oh!

Uh oh!

Neilxzn commented Sep 29, 2021

Uh oh!

hadoop-yetus commented Sep 29, 2021

Uh oh!

hadoop-yetus commented Sep 29, 2021

Uh oh!

Neilxzn commented Sep 30, 2021

Uh oh!

Uh oh!

adamantal left a comment

Uh oh!

hadoop-yetus commented Sep 30, 2021

Uh oh!

hadoop-yetus commented Sep 30, 2021

Uh oh!

adamantal commented Oct 1, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Neilxzn commented Sep 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

How was this patch tested?

For code changes:

Uh oh!

hadoop-yetus commented Sep 28, 2021

Uh oh!

Neilxzn commented Sep 29, 2021

Uh oh!

adamantal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Neilxzn commented Sep 29, 2021

Uh oh!

hadoop-yetus commented Sep 29, 2021

Uh oh!

hadoop-yetus commented Sep 29, 2021

Uh oh!

Neilxzn commented Sep 30, 2021

Uh oh!

Uh oh!

adamantal left a comment

Choose a reason for hiding this comment

Uh oh!

hadoop-yetus commented Sep 30, 2021

Uh oh!

hadoop-yetus commented Sep 30, 2021

Uh oh!

adamantal commented Oct 1, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Neilxzn commented Sep 28, 2021 •

edited

Loading